Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use session to store the last visited page #565

Merged
merged 4 commits into from Jul 9, 2019

Conversation

aschempp
Copy link
Member

@aschempp aschempp commented Jul 8, 2019

There is only one difference now that I can think of: If you open the login page, and then manually reload, the previous page will be gone…

@aschempp aschempp requested review from ausi, Toflar and leofeyer July 8, 2019 19:25
@leofeyer leofeyer added the bug label Jul 8, 2019
@leofeyer leofeyer added this to the 4.8 milestone Jul 8, 2019
Copy link
Member

@Toflar Toflar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@leofeyer
Copy link
Member

leofeyer commented Jul 9, 2019

If you open the login page, and then manually reload, the previous page will be gone

Will this also be the case if someone submits the form with invalid data?

@aschempp
Copy link
Member Author

aschempp commented Jul 9, 2019

If you open the login page, and then manually reload, the previous page will be gone

Will this also be the case if someone submits the form with invalid data?

No, why? Then the post value will be available, which points to the original referer.

@leofeyer
Copy link
Member

leofeyer commented Jul 9, 2019

Then I don't consider this a problem.

@leofeyer leofeyer merged commit 51c434e into master Jul 9, 2019
@leofeyer
Copy link
Member

leofeyer commented Jul 9, 2019

Thank you @aschempp.

@leofeyer leofeyer deleted the bugfix/last-page-visited branch July 9, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants